Ignore stream errors upon account successful account deletion and timeout during account creation #594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melvo
force-pushed
the
fix/account-creation-deletion-errors
branch
from
ed788ce
to
ad540bf
Compare
lnjX
reviewed
Nov 29, 2023
melvo
force-pushed
the
fix/account-creation-deletion-errors
branch
from
ad540bf
to
aa4a8de
Compare
lnjX
force-pushed
the
master
branch
10 times, most recently
from
84168ac
to
e614dcc
Compare
melvo
force-pushed
the
fix/account-creation-deletion-errors
branch
from
aa4a8de
to
10375af
Compare
melvo
force-pushed
the
fix/account-creation-deletion-errors
branch
6 times, most recently
from
b82efc3
to
80e6060
Compare
lnjX
reviewed
Sep 9, 2024
lnjX
changed the title
melvo
changed the title
melvo
force-pushed
the
fix/account-creation-deletion-errors
branch
from
80e6060
to
2c5cc3c
Compare
lnjX
reviewed
Sep 9, 2024
https://xmpp.org/extensions/xep-0077.html#usecases-cancel specifies the usage of the stream error <not-authorized/>. That is now handled as a valid response to the account deletion request instead of a result IQ stanza or in addition to it. The same applies to the stream error <conflict> since some servers send that instead of the <not-authorized/> stream error. There are servers closing the connection during account creation with a <connection-timeout/> stream error. That is now ignored.
melvo
force-pushed
the
fix/account-creation-deletion-errors
branch
from
2c5cc3c
to
bbfa81a
Compare
lnjX
approved these changes
Sep 9, 2024
lnjX
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR check list:
\since QXmpp 1.X,QXMPP_EXPORT-DBUILD_DOCUMENTATION=ON)doc/doap.xmlclang-format -i src/<edited-file(s)> tests/<edited-file(s)>Funded by NLnet via NGI Zero Entrust.